Update version of aiohttp in requirements

dolfies / discord.py-self

A fork of the popular discord.py for user accounts.

https://discordpy-self.rtfd.io/en/latest/

MIT License

683 stars 162 forks source link

Update version of aiohttp in requirements #330

Closed TheOnlyWayUp closed 2 years ago

TheOnlyWayUp commented 2 years ago

Summary

Fixes #275 and #325

General Info

For most people, updating aiohttp isn't the first thing that comes to mind when they encounter this error. Many people have faced this issue and figuring out how to fix it on your own isn't easy.

[x] If code changes were made then they have been tested.
[x] This PR fixes an issue (please put issue # in summary).

This issue can easily be prevented from occurring just by changing the required version of aiohttp

TheOnlyWayUp commented 2 years ago

I'd like to mention that while discord.py-self will work with any aiohttp version equal to or greater than 3.6.0 and lower than 4, and changing the required version to >=3.8.0,<4 won't really add anything, it'd reduce the amount of duplicate issues and discussions made because of this.

dolfies commented 2 years ago

Doesn't it work as low as 3.7.4?

TheOnlyWayUp commented 2 years ago

Doesn't it work as low as 3.7.4?

I'm not sure, I'll test it in a bit. If you're sure it's fixed post 3.7.3 (>=3.7.4), could you suggest a revision?

TheOnlyWayUp commented 2 years ago

@dolfies I believe this PR is ready to be merged, thanks for checking out the versions \:)