Added a banner color property to BaseUser - Githubissues

dolfies / discord.py-self

A fork of the popular discord.py for user accounts.

https://discordpy-self.rtfd.io/en/latest/

MIT License

680 stars 161 forks source link

Added a banner color property to BaseUser #394

Closed theAbdoSabbagh closed 1 year ago

theAbdoSabbagh commented 1 year ago

Summary

I noticed BaseUser does not have a property for banner color, so I added it. This PR has it.

General Info

[x] If code changes were made then they have been tested.
- [ ] I have updated the documentation to reflect the changes.
[ ] This PR fixes an issue (please put issue # in summary).
[x] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

Note

I have updated the documentation to reflect the changes.

I did add a description string to the property, but I didn't change the actual documentation of the library.

dolfies commented 1 year ago

Banner color is just a deprecated precursor to accent color. The fields are identical. This PR wouldn't function anyway as banner_color is a stringified hex representation of a color, not an integer.