dolfies / discord.py-self

A fork of the popular discord.py for user accounts.
https://discordpy-self.rtfd.io/en/latest/
MIT License
680 stars 161 forks source link

Change the default argument `limit` of `Messageable.history` to `50` instead of `100` #447

Closed Iinksafe closed 1 year ago

Iinksafe commented 1 year ago

Summary

The official client requests the channel's history with a limit of 50 messages.

What is the feature request for?

The core library

The Problem

When using Messageable.history, it will request a total of 100 messages.

The Ideal Solution

When using Messageable.history, it should request a total of 50 messages by default.

The Current Solution

Change limit's default value to 50 instead of 100.

Additional Context

image image

dolfies commented 1 year ago

Don't really feel like this breaking change is worth it, for something like this which anti-spam doesn't care about. If you want to adhere to client behavior you can pass the limit param to the function.