dolfies / discord.py-self

A fork of the popular discord.py for user accounts.
https://discordpy-self.rtfd.io/en/latest/
MIT License
688 stars 160 forks source link

Cut the voice recording from pycord and insert it into discord.py-self #580

Closed markmelix closed 1 year ago

markmelix commented 1 year ago

Summary

I've just had a problem when I had to record guild member's voice using my account as a self-bot (as I have no rights to just throw usual bot to the server). Thus, the only python library providing Discord API wrapping with self-bot support I can use is discord.py-self. As discord.py-self doesn't have fine voice recording support, I tried cutting py-cord's one and just inserting it directly into the discord.py-self code. I did some voice recording tests using my own self-bot and it works great. There were only changes to the voice related parts, so nothing breaks when I run usual bot. I decided to make a PR, maybe my changes would be useful.

General Info

dolfies commented 1 year ago

Thank you for the PR, but pycord's implementation has numerous issues and isn't something I want to include in this state.

However, there's an upstream PR that adds support for receiving audio. If/when that gets merged, I'll be happy to pull that in.