Fix editing features, Add report and change_voice_region.

dolfies / discord.py-self

A fork of the popular discord.py for user accounts.

https://discordpy-self.rtfd.io/en/latest/

MIT License

717 stars 163 forks source link

Fix editing features, Add report and change_voice_region. #95

Closed Buster-2002 closed 3 years ago

Buster-2002 commented 3 years ago

Summary

Fixed issue where 'features' wasn't seen as a valid edit_guild key. I don't even know why that input is being sanitized?? Added report and change_voice_region methods. The report method should ideally belong to a discord.Message, but user accounts can't fetch a message by ID.

General Info

[x] If code changes were made then they have been tested.
[x] This PR fixes an issue (please put issue # in summary).
[x] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

Buster-2002 commented 3 years ago

thanks for the feedback, I'll make the changes.

Yeah I know nothing about the contextproperties, I just wanted to make sure it worked!

A question though: Do you know why the call/ring endpoint doesn't seem to work? This my implementation currently:

        payload = {
            'recipients': recipients
        }
        context_properties = ContextProperties._from_dm_channel()
        r = Route('POST', '/channels/{channel_id}/call/ring', channel_id=channel_id)
        return self.request(r, json=payload, context_properties=context_properties)

AFAIK it either returns a bad request, or a 204 but either way nothing happends.

dolfies commented 3 years ago

Do you know why the call/ring endpoint doesn't seem to work?

Haven't looked into calls yet, sorry.

Buster-2002 commented 3 years ago

Wondering if you'd let me implement the entitlements/gift-codes/{nitro_code}/redeem endpoint?

dolfies commented 3 years ago

Wondering if you'd let me implement the entitlements/gift-codes/{nitro_code}/redeem endpoint?

Nitro/premium endpoints are going to be in a different PR as they aren't as simple as just wrapping the APIs. They're easy to get banned on.