Dolci/checkpointing time depend

dolfin-adjoint / pyadjoint

The algorithmic differentation tool pyadjoint and add-ons.

GNU Lesser General Public License v3.0

90 stars 35 forks source link

Dolci/checkpointing time depend #121

Closed Ig-dolci closed 7 months ago

Ig-dolci commented 8 months ago

Notes: Move the docstring from numpy-style to google-style.

Ig-dolci commented 7 months ago

Looks good. There are some comments regarding documentation and style in certain places.

Would also be good to a have a simple test for this in pyadjoint, not just in the firedrake.adjoint/firedrake_adjoint framework.

It is hard to build a pyadjoint test since the checkpointing will not work with AdjFloat. I do not understand deeply, but I think be no possible build Blocks and its outputs and dependencies with test based in arrays.