leleliu008
commented
1 month ago I am on a trip for the next few days. I will continue after I am back.
Open dolik-rce opened 1 month ago
leleliu008
commented
1 month ago I am on a trip for the next few days. I will continue after I am back.
github-actions[bot]
commented
1 month ago Coverage after merging netbsd into devel will be
| 84.94% | 0.00% |
|---|
| File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
|---|---|---|---|---|---|
| build.d | |||||
| version.cc | 100% | 100% | 100% | 100% | |
| src | |||||
| checker.cc | 56.82% | 100% | 78.57% | 54.24% | 108, 138–141, 144–147, 149, 151–157, 161–164, 166–170, 177–181, 189–194, 25–26, 28, 31, 34–35, 38, 40–41, 55–56, 85–90 |
| checker.h | 100% | 100% | 100% | 100% | |
| config.cc | 69.06% | 100% | 77.27% | 68.16% | 101–103, 136, 144–145, 148–149, 156, 160, 163, 169–170, 172–173, 177–178, 180–181, 183–184, 186–189, 191, 194, 199, 203, 208, 275, 289, 300–302, 307, 309, 313, 318–320, 325, 356–357, 73, 75–82, 84–85, 88–91, 93–94, 96–98 |
| config.h | 100% | 100% | 100% | 100% | |
| log.cc | 100% | 100% | 100% | 100% | |
| log.h | 88.64% | 100% | 78.26% | 100% | |
| main.cc | 82.61% | 100% | 100% | 81.82% | 13, 23, 52–54, 61, 69–74 |
| optimizer.cc | 97.62% | 100% | 100% | 97.36% | 455–456, 522–524, 526–528, 530–531 |
| packcc_wrapper.c | 100% | 100% | 100% | 100% | |
| parser.cc | 89.07% | 100% | 92.31% | 88.54% | 149–152, 155–156, 178, 189, 208–212, 215–219 |
| parser.h | 100% | 100% | 100% | 100% | |
| utils.cc | 83.33% | 100% | 93.33% | 81.72% | 102–105, 109, 115, 129, 147–148, 35, 45, 80, 87–90, 94 |
| src/ast | |||||
| action.cc | 87.30% | 100% | 75% | 90.20% | 7, 72–73, 76–77 |
| action.h | 100% | 100% | 100% | 100% | |
| alternation.cc | 90% | 100% | 88.24% | 90.41% | 110–111, 19–20, 54, 6, 69 |
| alternation.h | 100% | 100% | 100% | 100% | |
| capture.cc | 69.84% | 100% | 66.67% | 70.59% | 21–22, 26–27, 37, 42, 45, 5, 59, 67–68, 75–76, 79–80 |
| capture.h | 100% | 100% | 100% | 100% | |
| character_class.cc | 91.53% | 100% | 91.30% | 91.56% | 11–14, 159, 177–179, 39, 42–43, 58–59 |
| character_class.h | 100% | 100% | 100% | 100% | |
| code.cc | 78.05% | 100% | 71.43% | 79.41% | 29, 37, 43–44, 7–9 |
| code.h | 100% | 100% | 100% | 100% | |
| directive.cc | 91.55% | 100% | 75% | 93.65% | 5, 79, 88–89 |
| directive.h | 100% | 100% | 100% | 100% | |
| expand.cc | 80.43% | 100% | 72.73% | 82.86% | 20, 4, 42–43, 46–47 |
| expand.h | 100% | 100% | 100% | 100% | |
| grammar.cc | 80.31% | 100% | 78.57% | 80.53% | 123, 133, 135–136, 141, 147–148, 17–18, 20–22, 47, 5, 68–69, 81, 87–88, 9, 96–97 |
| grammar.h | 100% | 100% | 100% | 100% | |
| group.cc | 90.28% | 100% | 100% | 87.72% | 21–22, 26–27, 42, 45, 59 |
| group.h | 100% | 100% | 100% | 100% | |
| node.cc | 74.53% | 100% | 76.47% | 74.16% | 113–129, 133–134, 15–16, 30, 73 |
| node.h | 93.41% | 100% | 92.31% | 94.87% | 104, 122 |
| reference.cc | 90.91% | 100% | 90.91% | 90.91% | 19, 41, 45, 5 |
| reference.h | 100% | 100% | 100% | 100% | |
| rule.cc | 76.74% | 100% | 72.22% | 77.94% | 22–23, 37, 5, 54, 66–69, 76–79, 82–83 |
| rule.h | 100% | 100% | 100% | 100% | |
| sequence.cc | 92.63% | 100% | 94.44% | 92.21% | 16–17, 4, 48, 57, 83 |
| sequence.h | 100% | 100% | 100% | 100% | |
| string.cc | 97.37% | 100% | 100% | 96.43% | 22 |
| string.h | 100% | 100% | 100% | 100% | |
| term.cc | 86.78% | 100% | 88.24% | 86.43% | 110, 122, 124, 155–157, 179–181, 183–185, 4, 59–60, 73–74, 90, 98 |
| term.h | 100% | 100% | 100% | 100% | |
FYI @leleliu008: I have tried slightly different approach for the NetBSD. Using cross-platform-actions/action that runs the build in QEMU, to make sure the problem is not in the cross-compilation. It's even slightly better IMHO, because it allows to test the resulting binary.
Bad news is that it still fails on missing
<filesystem>on the 9.x versions. Good news is that the code successfully compiles on NetBSD 10.0, there is probably newer gcc. It than fails the tests (in very similar way to macOS), but that should be fixable.