search

dolik-rce / pegof

PEG grammar optimizer and formatter
Other
9 stars 2 forks source link

Run the test on GitHub Actions #8

Closed masatake closed 2 months ago

masatake commented 2 months ago

style.bats is turned off temporarily because it requires newer bats than ones installed to CI/CD environments.

dolik-rce commented 2 months ago

I've got some time to play with this last night and I've managed to make it work. There were some problems with cmake ignoring the clang toolchain (e.g.: it used /usr/bin/c++, which points to g++ by default) and I have also changed the style.d test to work with older versions of bats. See da13845e115d5bf897f2dbded1675c99e7c49be9 if you are interested in details.

masatake commented 2 months ago

Could you cherry pick https://github.com/dolik-rce/pegof/pull/8/commits/3c0e6268a56646bfb07e00a5e49b1c8e037524fb ?

dolik-rce commented 2 months ago

Could you cherry pick https://github.com/dolik-rce/pegof/commit/3c0e6268a56646bfb07e00a5e49b1c8e037524fb ?

I already did :slightly_smiling_face: It was a bug, so I applied the fix immediately.

masatake commented 2 months ago

Could you cherry pick https://github.com/dolik-rce/pegof/commit/3c0e6268a56646bfb07e00a5e49b1c8e037524fb ?

I already did 🙂 It was a bug, so I applied the fix immediately.

Thank you.

Unfortunately, I'm quite busy at the moment and I probably won't be able to get to it in the next week or two.

Please, go slow.