search

dolittle-obsolete / DotNET.Fundamentals

Reusable, fundamental abstractions and building blocks
http://www.dolittle.io
MIT License
4 stars 8 forks source link

Add dotnet path for Ubuntu 19.04 for AssemblyResolvers #262

Closed joelhoisko closed 4 years ago

joelhoisko commented 4 years ago

Tested on Ubuntu 19.04 on a dolittle project.

Fixes issues https://github.com/dolittle-fundamentals/DotNET.Fundamentals/issues/258 and https://github.com/dolittle-fundamentals/DotNET.Fundamentals/issues/244, not the prettiest fix and in the future we probably could do with letting the user specify the path or having a more robust/general dotnet path discovery function/tool.

┆Issue is synchronized with this Asana task

TomasEkeli commented 4 years ago

Should we have multiple fallback paths, and try each and every one if we fall back? That way we can just add new ones when we discover a platform with this problem.

Or, you know, everyone could use the same environment ;)

joelhoisko commented 4 years ago

Having a specific tool/function to find the correct path from a list of possibilities would be great and then if none of those paths work we could give the user the chance to specify their own path, aka --dotnet-path=/users/weird/dotnet/folder/ or/and have a configuration file for this. This would require us to fail earlier with a more clear error message too instead of complaining about some random missing dll's basically.

einari commented 4 years ago

These paths shouldn't be that dynamic and you should be able to get them by doing "dotnet info" - which suggests we should tap into what they're doing themselves.