dollabs / pamela

Probabalistic Advanced Modeling and Execution Learning Architecture
Apache License 2.0
233 stars 13 forks source link

`tpn` task creates bogus end-nodes #103

Closed pmdoll closed 7 years ago

pmdoll commented 7 years ago

See issue #101 and use first.pamela for details. I am blocked on this issue

tmarble commented 7 years ago

@pmdoll could you please elaborate?

pmdoll commented 7 years ago

For node-102, end-node is node-99 but there is no object for node-99.

"node-102": {
  "tpn-type": "state",
  "uid": "node-102",
  "constraints": [],
  "activities": [
    "act-101"
  ],
  "incidence-set": [
    "act-92"
  ],
  "end-node": "node-99"

On May 2, 2017, at 11:54 AM, Tom Marble notifications@github.com wrote:

@pmdoll https://github.com/pmdoll could you please elaborate?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dollabs/pamela/issues/103#issuecomment-298677680, or mute the thread https://github.com/notifications/unsubscribe-auth/ANp3gxCsQmFliDduOTai-4xBxFFiX3P7ks5r11G8gaJpZM4NOONY.

tmarble commented 7 years ago

Was able to reproduce with

tmarble@cerise 526 :) ./bin/pamela -i test/pamela/first.pamela -o first -f edn -t "(main-htn.tpn.start)" htn
tmarble@cerise 530 :) ../planviz/bin/planviz -i first.tpn.edn=first.htn.edn
17-May-02 12:29:45.547 cerise WARN [planviz.server:0] - 
PLANVIZ server ready

NOTE: the TPN renders correctly in PLANVIZ. The symptom appears to be that certain state nodes have an invalid :end-node (which is likely due to a bug in remove-superfluous-null-activities.