Better handling of reserved symbols

dollabs / pamela

Probabalistic Advanced Modeling and Execution Learning Architecture

Apache License 2.0

233 stars 13 forks source link

Closed tmarble closed 7 years ago

tmarble commented 7 years ago

Plant functions can begin with any of the reserved function symbols (Closes #121) Upgraded instaparse dependency

Grammar changes:

An essential understanding of Instaparse negative lookahead is that the following token must be speciefied. In the updated grammar this is represented by the new terminal 'stop-token'.
The various *-opt terminals were refactored
Certain right hand side rules were better ordered and formatted.
insta2w3c was improved for generating updated railroad diagrams
The railroad diagram was updated

Signed-off-by: Tom Marble tmarble@info9.net

tmarble commented 7 years ago

Note for more background on Instaparse negative lookahead please see https://github.com/Engelberg/instaparse/issues/116

dcerys commented 7 years ago

Since there are a large number of IR changes (deltas in the ir.edn files), let's describe them in doc/IR-CHANGELOG.md. Sorted keys, etc.

tmarble commented 7 years ago

@dcerys

There are no other cases of :pclass-name in rubrics as this was the only rubic that contained "check" (i.e. the AST tree from Instaparse) output
Regarding the IR rubric changes it is essential to know that after fixing the grammar that boot test --namespaces testing.pamela.parser passed 100% indicating proper semantic comparison of the maps. I checked in new rubrics to ensure that they are also syntactically identical (benefiting from the previous changes in sorting maps).
I couldn't envision a use case where we needed other stop-token's b/c it would look like SYMBOL MAP-OR-VECTOR-LITERAL together.