dollabs / pamela

Probabalistic Advanced Modeling and Execution Learning Architecture
Apache License 2.0
233 stars 13 forks source link

Inheritance 2 #160

Closed pmdoll closed 7 years ago

pmdoll commented 7 years ago

Work in progress towards inheritance implementation.

tmarble commented 7 years ago

@pmdoll it seems the changes to test-mode don't actually improve things in the spirit of #117?

About inheritance.clj

About parser.clj

Do the new rubrics reflect the current design on the wiki?

tmarble commented 7 years ago

@pmdoll there's a little destructuring trick you can do at test/clj/testing/pamela/inheritance.clj:78 which is instead of...

   (let [file (first files)
            expected (second files)

you can do this...

   (let [[file expected] files

Re: test/pamela/inherit2.expected.pamela I thought the wiki specifies combining mode cond-expr's disjunctively?

Re: test/pamela/inherit-union.expected.pamela I understand choosing priority based on the "class inheritance order", but this doesn't seem to be documented anywhere as the approach (i.e. not discussed in the wiki)?

At the moment there is no call from the parser ns to inheritance... is the idea that the inheritance ns will develop on the side until it's ready and then be integrated in the parsing of every file?

Otherwise it seems fine and we should probably get @dcerys input.