[version] patch version bump; pin puppeteer

dollarshaveclub / e2e

Make End-to-End Testing Great For Once

MIT License

32 stars 3 forks source link

[version] patch version bump; pin puppeteer #32

Closed yowainwright closed 5 years ago

yowainwright commented 5 years ago

Update

Pins puppeteer.

Puppeteer is one of a few deps e2e needs. Puppeteer consistently releases updates that break e2es. This PR pins puppeteer to its last working version for e2e.

Further action

If a CODEOWNER file was added, Greenkeeper updates (for Puppeteer) would automatically show up in an email of the codeowners. This would allow for easy updates of Puppeteer in e2e and keep Puppeteer from suddenly breaking and blocking code updates.

brian-gates commented 5 years ago

@yowainwright how do you feel about leveraging package-lock instead?

yowainwright commented 5 years ago

@brian-gates I want that. Within some of our repos, circle fails with our ci setup and package-lock.json. It is probably a small fix that I haven't looked in to.

Net-net: Moving forward = YES!