Quite mode doesn't work

dollarshaveclub / es-check

Checks the version of ES in JavaScript files with simple shell commands 🏆

https://github.com/yowainwright/es-check

MIT License

459 stars 38 forks source link

Quite mode doesn't work #113

Open dmt0 opened 4 years ago

dmt0 commented 4 years ago

Passing --quiet flag doesn't do anything. I'm still getting ES-Check: there were no ES version matching errors! 🎉 (I'm getting it on a file that doesn't work in IE11, but that's another issue...)

heythisispaul commented 4 years ago

Yeah I don't even see it being consumed as an option unless I'm missing it somewhere else. I'm not sure if that feature is actually supported.

Edit: I looked more into this, and realized that that flag is actually supposed to be coming from one of the dependencies, caporal.

sbc100 commented 4 years ago

Can we make this flag work? I might even suggest that it be the default. I think its good practice for verifiers and validators be silent by default (or at least have an option).