Closed GUI closed 4 years ago
Can we merge PR?
Any update on this?
Hey, any updates?
Hey, did this got lost? What's blocking the merge?
@jakiestfu Thank you for merging this PR! Any ETA when a new release of es-check
will be published to npmjs.com?
Any update on a release? We'd like to upgrade to take care of vulnerabilities reported for Acorn.
es-check pins the acorn dependency to 6.1.1, which has a security issue: https://www.npmjs.com/advisories/1488
You'd have to run untrusted user input through es-check for this to potentially be an issue, so I'm not sure how likely that is. However, it would still be nice to get this patched and a new version of
es-check
released so that this doesn't cause issues innpm audit/yarn audit
types of vulnerability reports wheneveres-check
is used.Proposed Changes
acorn
dependency requirement from6.1.1
to^6.4.1
. Versions 6.4.1 or 7.1.1 and later of acorn are patched. I thought it might be beneficial to loosen the version constraint at the same time, so potentially future patches on the 6.x series could automatically be upgraded, rather than requiring explicit upgrades on es-check's part. But let me know if you'd prefer keeping it pinned to an exact version, and happy to update this pull request.Thanks!