dollarshaveclub / es-check

Checks the version of ES in JavaScript files with simple shell commands 🏆
https://github.com/yowainwright/es-check
MIT License
459 stars 38 forks source link

Update acorn dependency for security updates #114

Closed GUI closed 4 years ago

GUI commented 4 years ago

es-check pins the acorn dependency to 6.1.1, which has a security issue: https://www.npmjs.com/advisories/1488

You'd have to run untrusted user input through es-check for this to potentially be an issue, so I'm not sure how likely that is. However, it would still be nice to get this patched and a new version of es-check released so that this doesn't cause issues in npm audit/yarn audit types of vulnerability reports whenever es-check is used.

Proposed Changes

Thanks!

apepper commented 4 years ago

Fixes https://github.com/dollarshaveclub/es-check/issues/115.

bigsergey commented 4 years ago

Can we merge PR?

cssagogo commented 4 years ago

Any update on this?

AnaA95 commented 4 years ago

Hey, any updates?

ceisele-r commented 4 years ago

Hey, did this got lost? What's blocking the merge?

apepper commented 4 years ago

@jakiestfu Thank you for merging this PR! Any ETA when a new release of es-check will be published to npmjs.com?

stevehobbsdev commented 4 years ago

Any update on a release? We'd like to upgrade to take care of vulnerabilities reported for Acorn.