dollarshaveclub / es-check

Checks the version of ES in JavaScript files with simple shell commands 🏆
https://github.com/yowainwright/es-check
MIT License
459 stars 38 forks source link

bug #95

Closed En777 closed 5 years ago

En777 commented 5 years ago

Requested Update

Why Is This Update Needed?

Are There Examples Of This Requested Update Elsewhere?

Read about references issues here. Provide paragraph text responses to each header.

En777 commented 5 years ago

package.json: npm scripts: "es5-check": "es-check es5 ./dist/*/.js"

if I npm run es5-check finished, all files passed check, but it log:

ES-Check: there were no ES version matching errors!  🎉

because: https://github.com/dollarshaveclub/es-check/blob/master/index.js#L173

   if (errArray.length > 0) {
      // ...
    }
    logger.error(`ES-Check: there were no ES version matching errors!  🎉`)

so, if no error info, it will log a no ES version error. pls fix.

En777 commented 5 years ago

my mistake.