search

dolohow / uksm

Ultra Kernel Samepage Merging
242 stars 35 forks source link

Why is ksm.h relicensed to GPL 3.0 in this patch? #56

Closed abucodonosor closed 4 years ago

abucodonosor commented 4 years ago

Hello,

https://github.com/dolohow/uksm/blob/master/v5.x/uksm-5.5.patch#L149-L150 relicenses the file to GPL 3.0.

Why?.

dolohow commented 4 years ago

@naixia Are you able to explain?

pfactum commented 4 years ago

I'm not sure @naixia will respond. I haven't seen him online for quite some time, and given his last message here was about him being ill, the outcome might be not the most pleasant.

abucodonosor commented 4 years ago

Well, the file cannot be relicensed like this, I assume it is a typo or alike.

Meanwhile, can you just remove that hunk because it is a GPL violation.

pfactum commented 4 years ago

OK, I've got a reply from his colleague in Nanjing.

He is much better now, but still in a recovery procedure. Cannot work at this time.

He asked me to say "hello and take care" to you, thanks you for so many years' support.
dolohow commented 4 years ago

Meanwhile, can you just remove that hunk because it is a GPL violation.

I think GPLv3 is compatible with GPLv2. Not sure why was relicensed though.

Care to send PR @abucodonosor?

abucodonosor commented 4 years ago

It is not a matter of being compatible, you cannot relicense other's work without an agreement of everyone who owns that code. In the Kernel case that cannot be done, ever, it is GPLv2 only. Modules could have a dual GPLv2 / something license but that is about it.

A PR against a patch? Or do you want a PR like a 're-diffing' of the patch against some kernel-version(s)?

dolohow commented 4 years ago

Fixed in 5.7. Anyone care to port to older patches?

And also thanks @abucodonosor for report.

Best