search

dolphin-acoustics-vip / artwarp

MATLAB program for automated categorisation of tonal animal sounds
https://github.com/dolphin-acoustics-vip/artwarp/wiki
GNU Lesser General Public License v3.0
7 stars 10 forks source link

Fixed issue in Load_Data with changing the working directory #10

Closed tristankleyn closed 2 years ago

tristankleyn commented 3 years ago

The original code wouldn't allow me to load data (and others have apparently run into this problem too). Seems to work fine when changed to cd(path) instead.

olexandr-konovalov commented 3 years ago

@tristankleyn thanks! I see that @RohanK22 made a similar change elsewhere. Would it make sense to check other files, they may have the same problem?

tristankleyn commented 3 years ago

yes, that would probably be a good idea. I'll have a look and see if I can find anything similar elsewhere

olexandr-konovalov commented 2 years ago

@tristankleyn have you managed to check for other cases needing similar change?

tristankleyn commented 2 years ago

Yes, the same line of code eval(['cd ' path]) is also used in these files below, however I haven't run into an issue with these yet. Might still be worth changing it to cd(path) for consistency?

ARTwarp_Assess_Net.m (line 3) ARTwarp_Load_CSV_Data.m (line 9) ARTwarp_Load_TabDelim_Data.m (line 14)

olexandr-konovalov commented 2 years ago

@tristankleyn think so!