search

dolphin-acoustics-vip / artwarp

MATLAB program for automated categorisation of tonal animal sounds
https://github.com/dolphin-acoustics-vip/artwarp/wiki
GNU Lesser General Public License v3.0
7 stars 10 forks source link

Maximum warp factor is hard-coded in warp.m, not changeable #39

Open lixitrixi opened 1 year ago

lixitrixi commented 1 year ago

https://github.com/dolphin-acoustics-vip/artwarp/blob/07925a077748ae4eb426d6e34d6b9666cc6277c5/warp.m#L19

The above code explicitly checks if the difference in lengths of two contours is greater than 3, rather than using the warpFactorLevel parameter as expected.

olexandr-konovalov commented 1 year ago

@lixitrixi good catch - a pull request with a fix is welcome!

olexandr-konovalov commented 9 months ago

Seems this line disappeared. TODO: check if this is obsolete or fix needed in another location