Open olexandr-konovalov opened 9 months ago
This looks manageable - 6 files changed and not 55 like it was in #50!
However, we have failed test - needs to be investigated:
Error occurred in network_test/network_test and it did not run to completion.
---------
Error ID:
---------
'MATLAB:TooManyInputs'
--------------
Error Details:
--------------
Error using NetworkFactory.new_network
Too many input arguments.
Error in network_test (line 6)
network = NetworkFactory.new_network(contours);
Test failed because of
================================================================================
Error occurred in network_test/network_test and it did not run to completion.
---------
Error ID:
---------
'MATLAB:TooManyInputs'
--------------
Error Details:
--------------
Error using NetworkFactory.new_network
Too many input arguments.
Error in network_test (line 6)
network = NetworkFactory.new_network(contours);
================================================================================
Seems that some function changed the number of arguments, but the test was not adjusted.
I have rebased this, hoping that we can also see code coverage for this PR - however, the test terminates because of the error prior to uploading results to Codecov.
Now part of this was added in PR #64 by @tatedunbar which has been merged. After that Iv'e rebased this PR #51, so we can now see what's left. @tatedunbar please check if there is anything else what we need to salvage, and then make another PR if you want to backport more of Michael's changes. Thanks!
Attempt to do PR #50 properly. Submitted this PR using an archive provided to us by @vmjanik via MS Teams for the Dolphin Acoustics VIP.