search

dolphin-acoustics-vip / artwarp

MATLAB program for automated categorisation of tonal animal sounds
https://github.com/dolphin-acoustics-vip/artwarp/wiki
GNU Lesser General Public License v3.0
7 stars 10 forks source link

Add modified changes by Michael Stanway to Category.m #58

Closed tatedunbar closed 8 months ago

tatedunbar commented 8 months ago

Just adding Michael's changes to Category.m, none of which should affect tests. I left variable names same as the original rather than using new ones because they are sufficiently descriptive.

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 75.55%. Comparing base (1b1009b) to head (2ec9833).

:exclamation: Current head 2ec9833 differs from pull request most recent head ceae11e. Consider uploading reports for the commit ceae11e to get more accurate results

Files Patch % Lines
Category.m 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #58 +/- ## =========================================== - Coverage 87.17% 75.55% -11.63% =========================================== Files 7 7 Lines 39 45 +6 =========================================== Hits 34 34 - Misses 5 11 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

olexandr-konovalov commented 8 months ago

@tatedunbar thanks! I wonder if it would be sensible to add some tests now, or is there a plan to add more code and tests later?

tatedunbar commented 8 months ago

@olexandr-konovalov I'm unsure why the tests I added in the most recent commit are failing. It has something to do with too many arguments being passed to add and remove, but I don't see how that could be happening. Could you take a look at it?