Closed tatedunbar closed 7 months ago
@tatedunbar thanks! Have you seen the logs at https://github.com/dolphin-acoustics-vip/artwarp/actions/runs/8309001737/job/22739868982?pr=64 ? Do the errors make sense?
@olexandr-konovalov I've looked at the errors but can't quite understand them because, as far as I can tell, I've passed the right number of arguments to add().
@tatedunbar ok, will try to look later. BTW, this is a useful post on writing commit message - the one use used in 32878db3e3bc426bdff9d1d2d183c04fc996c18a has too 1st line, and e.g. GitHub shows it in an abbreviated way...
Hm, I see... Does it work locally on your computer @tatedunbar ?
================================================================================
Error occurred in category_test/category_test and it did not run to completion.
---------
Error ID:
---------
'MATLAB:TooManyInputs'
--------------
Error Details:
--------------
Error using Category/add
Too many input arguments.
Error in category_test (line 14)
cat.add(cat, contours(2));
================================================================================
@olexandr-konovalov no, it doesn't
Attention: Patch coverage is 31.25000%
with 33 lines
in your changes are missing coverage. Please review.
Project coverage is 55.29%. Comparing base (
1b1009b
) to head (c67e253
).
Files | Patch % | Lines |
---|---|---|
Network.m | 16.00% | 21 Missing :warning: |
NetworkFactory.m | 0.00% | 11 Missing :warning: |
Category.m | 88.88% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Everything seems to be working now with changes to both Category and Network.
Ok, thanks @tatedunbar. Do you plan to add more commits to this PR ?
@olexandr-konovalov I believe that this is fully complete at this point. I've just added a couple more comments to functions.
Redo of PR #58, which was accidentally deleted. This contains updates to Category.m, Network.m, and new tests for Category.m currently. Currently these new tests are failing, but I'm unsure why, so if someone else could look at them, that would be helpful.