dolphin-emu / fifoci

Continuous integration service running Dolphin FIFO logs to find graphics rendering regressions
BSD 2-Clause "Simplified" License
49 stars 21 forks source link

runner: Use subprocess.call instead of os.system. #18

Closed CrossVR closed 8 years ago

CrossVR commented 8 years ago

Windows can't handle command lines larger than 8191 characters. At first I wanted to reduce the command-line length, but it looks like there was a much easier fix to handle huge command lines.

subprocess.call is intended to replace os.system and does allow for larger command-lines. I tested this locally on my own Windows setup and it works fine.

I also added some config changes so the analytics are off by default or else the FIFO log won't run because it's waiting for user input.