search

dolphin-emu / hwtests

Hardware test suite
GNU General Public License v2.0
22 stars 25 forks source link

CGX_DoEfbCopyTex: Use DCInvalidateRange instead of DCFlushRange #48

Closed Pokechu22 closed 2 years ago

Pokechu22 commented 2 years ago

See https://github.com/dolphin-emu/hwtests/pull/44#discussion_r856676264.

neobrain commented 2 years ago

Looks good - FWIW, I think when I wrote this code I probably barely understood the difference between flushing and invalidating, so if you find any more of these there's a decent chance they are just as wrong as this one :)

Pokechu22 commented 2 years ago

This is the only use of ogc/cache.h or any function beginning with DC so I think we're good.