search

dolphin-emu / www

Dolphin Emulator official website source code (running on https://dolphin-emu.org/)
MIT License
120 stars 68 forks source link

Fix title and description in Discord previews (and possibly other sites) #131

Closed leoetlino closed 3 years ago

leoetlino commented 3 years ago

og:title was hardcoded to "Dolphin Emulator" instead of being set to the article title or the page name.

og:type was set to an invalid value.

og:image is a dead link, and it was pointing to an image hosted on Facebook's CDN for some reason (???). Just remove it and let crawlers figure out what image to show (usually the article banner).

This should fix article previews showing "Dolphin Emulator - Dolphin Emulator" with no image in Discord.

leoetlino commented 3 years ago

Unfortunately, Discord isn't smart enough to show the article banner most of the time. Addressing this will require somehow extracting the image URL from the article body so that we can generate the og:image meta tag. Or adding a property to article entries.

But let's fix previews first.

trzj commented 3 years ago

Bro who tf are u

sri, 28. srp 2021. 03:06 Léo Lam @.***> je napisao:

Unfortunately, Discord isn't smart enough to show the article banner most of the time. Addressing this will require somehow extracting the image URL from the article body so that we can generate the og:image meta tag. Or adding a property to article entries.

But let's fix previews first.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dolphin-emu/www/pull/131#issuecomment-887933421, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT5GVFXKJBX6QLKNPPZNW2LTZ5JZ7ANCNFSM5BBC3JUQ .