Open GuitarBro opened 2 years ago
This is a little bit risky because old articles might be relying on Bootstrap CSS (for responsive embeds, and maybe layout and centering utils like text-center, float/pull-right, etc.) This will need to be carefully tested to ensure articles don't break.
@leoetlino agreed. Is it possible to get a copy of the article data locally? I'd be happy to give it a look through for compatibility issues, I just lack the means to do it.
Any chance I could get some visibility on this? It looks like #140 implements a dark theme that would be incompatible with Bootstrap 5.1 which is unfortunate. I was planning to work on implementing one of the compatible themes from bootstrap-dark-5 once this was approved, but without a way to verify the condition of the existing articles, this can't go in yet.
Perhaps since #140 has no conflicts, that one should be merged for the time being with a plan to eventually replace it with a bootstrap-dark-5 theme once this gets merged? Alternatively, I can work on adding it to this pull request if that makes more sense.
First PR here, so go easy on me. 😉
This one's fairly self-explanatory. I upgraded the Bootrstrap version from 3 to 5.1, attempting to preserve the general layout/content while making things look more modern.
Notable changes:
Other things to mention: I'm not sure if there's any reason to have the jQuery dependency anymore since Bootstrap 5.x no longer requires it and ekko lightbox is gone. I left it just in case, but if those were the only places it was used, perhaps that should be removed as well to reduce page load times.
Pretty confident I got all the pages that needed attention, but I may have missed something so let me know if I need to revisit this.
Side note: CTRL/CtrlSTheWorld/GuitarBro all are me, just in case there's any confusion. Sorry about the inconsistency across git/github.