dolphin-emu / www

Dolphin Emulator official website source code (running on https://dolphin-emu.org/)
MIT License
120 stars 68 forks source link

Dark Mode Support #140

Open Basketballforce opened 2 years ago

Basketballforce commented 2 years ago

Hey there Dolphin team!

I figured it was time that the Dolphin site had a dark/light mode toggle so I took a stab at it.

These changes include:

Notes:

Thank you! BasketballForce

Basketballforce commented 2 years ago

Uploading some screenshots for reference. A local version with just the plain html, css, and js can be found here 1 2 3 4 5 6 7

MayImilae commented 2 years ago

Why orange?

Basketballforce commented 2 years ago

Its the color invert (inverted color) of the Dolphin blue logo.

I think it gives the dark mode its own unique flare but, changing this back to the classic blue would be very easy and do-able if preferred!

MayImilae commented 2 years ago

Definitely would be preferred. We use blue everywhere already, plus... bright orange on black is rather piercing imo.

Basketballforce commented 2 years ago

I went and reverted the color changes from orange to the original blue. I have attached some screenshots for reference. I haven't updated the pull request since the original blue in dark mode doesn't have the best color contrast and dark mode experience (imo).

I will try to select a more "dark friendly" blue color scheme/theme that aligns to the original design. After which I will add more screenshots for reference and update the pull requests

1ogBlue ogBlue2 ogBlue3 ogBlue4 ogBlue5 ogBlue6

Basketballforce commented 2 years ago

After second review, the original blue looked perfectly fine for dark mode. Smaller additional edits have been made for quality of life. These are:

1) Links on the darker background/black background have been made a lighter shade of blue for color contrast sake. 2) Spacing between the light/dark mode icons and the hamburger toggle for mobile view has been increased for clearer/consistent separation of elements. 3) Button styling for the downloads page (btn-info) has been reverted back to original

The code has been updated/pushed to the pull request. Dark mode looks very similar to the most recent changes above in which dark mode was reverted to blue. I will add one or two screenshots below to reflect the new changes.

updatedBlue updatedBlue2 HamburgerSeperate

osfanbuff63 commented 2 years ago

This looks great, and I'm picky with dark mode :P

For comparison, here's Dark Reader's automatic dark mode: Screenshot 2022-06-22 181505

The native dark mode is almost always better than that too.