search

dolphin-emu / www

Dolphin Emulator official website source code (running on https://dolphin-emu.org/)
MIT License
120 stars 68 forks source link

rename every instance of "stable" to "legacy" #151

Closed cobalt2727 closed 1 year ago

cobalt2727 commented 1 year ago

to the best of my knowledge this is only done on instances of the entire word, matching case sensitivity

I'm not sure if/how this would break non-English languages, feedback on that is welcome

MayImilae commented 1 year ago

The intention is to change stables to releases in the future, but that is indefinitely stalled out so this is a good option to clear up confusion in the meantime.

BTW you probably should also change the stable track in the updater to legacy too. Will you be doing that in a separate PR?

OatmealDome commented 1 year ago

Does anyone know how is localization handled on the website? I know for the main emulator it is handled by Transifex and you're not supposed to change the strings in the po files manually. Not sure if it's the same here.

cobalt2727 commented 1 year ago

The intention is to change stables to releases in the future, but that is indefinitely stalled out so this is a good option to clear up confusion in the meantime.

BTW you probably should also change the stable track in the updater to legacy too. Will you be doing that in a separate PR?

I can look into that when I get some time, although I'm thinking that might take more work than a "replace all" in VS Code...

JosJuice commented 1 year ago

Does anyone know how is localization handled on the website? I know for the main emulator it is handled by Transifex and you're not supposed to change the strings in the po files manually. Not sure if it's the same here.

I believe it's the same here. However, the process of syncing the strings with Transifex has been handled by delroth instead of by me.

Dentomologist commented 1 year ago

FYI, Stable was already removed from the updater in https://github.com/dolphin-emu/dolphin/pull/11457.

MayImilae commented 1 year ago

FYI, Stable was already removed from the updater in dolphin-emu/dolphin#11457.

Oh, I forgot about that. Nevermind then!

OatmealDome commented 1 year ago

@JosJuice Are you able to handle a Transifex sync for this repo too? I assume this will be the same process, though I have no experience with Transifex.

JosJuice commented 1 year ago

Are you able to handle a Transifex sync for this repo too? I assume this will be the same process, though I have no experience with Transifex.

The exact process would be a little different since this is a different code base in a different programming language, , but I will try to look into it when I get time. It's probably not too complicated.

OatmealDome commented 1 year ago

Superseded by #152.