search

dolphinsmalltalk / Dolphin

Dolphin Smalltalk Core Image
MIT License
301 stars 58 forks source link

resource_Default_view comments aren't all up to date #1121

Closed brickviking closed 3 years ago

brickviking commented 3 years ago

Describe the bug Several methods in MVP/ no longer have correct evaluate lines in their comments due to the recent namespacing. The same is true for other resource_*_view methods I've seen so far.

To Reproduce Steps to reproduce the behaviour:

  1. Go to class-side method resource_Default_view under most MVP classes
  2. Check the "eval the following method" comment
  3. Scroll down to 'ViewComposer openOn: ...'
  4. If we have Tools.ViewComposer, that's correct. Most do not, they simply have ViewComposer.

Expected behaviour Comments for resource_Defaultview or other resource*_view methods should be kept up to date along with the code in the rest of the method.

Please complete the following information):

Additional context I'll create pull requests for at least the MVP hierarchy to correct the comments in those methods, and I'll split them out per subset so I can find any mistakes I make. This should be one of those "low-hanging fruit" kind of jobs. Let me know if you already have this in hand.

brickviking commented 3 years ago

Related pull has been closed, so I'll close this now. I may have some further text edits coming down the pipe but I'll batch those up much like I did these ones.