dolphinsmalltalk / Dolphin

Dolphin Smalltalk Core Image
MIT License
301 stars 58 forks source link

[Docs] Intent of paragraph in STONReader.cls #1130

Closed brickviking closed 3 years ago

brickviking commented 3 years ago

I'm a little confused as to how the following paragraph from Core/Object Arts/Dolphin/System/STON/STON.Reader.cls:29:1490 is supposed to read. So far, I've managed to wrestle it into the following:

... There is potential danger in using a swapping become: for classes that use the normal STON object representation, but which create some sort of external reference while the object itself is being instantiated (e.g. a registry for sharing), and which may internal references. ...

Should I tweak it so it says: and which may have internal references. or, do I put: and which may not have internal references?

Cheers, brickviking

blairmcg commented 3 years ago

may have

brickviking commented 3 years ago

Thank you. I'm just working my way through all of the comments and strings and trying to find obvious stuff, I think I've got about 15% done so far. Do you want me to batch them up and push them all through at once, or send them through in smaller lumps of about 20-30 files?

brickviking commented 3 years ago

Core/Object Arts/Dolphin/Sockets/Socket.cls:121 says this:

    "Connect to the socket to a ServerSocket without blocking. 

Should this read

I'm aware this package has been superseded by the more modern Dolphin Sockets package. Cheers again.

blairmcg commented 3 years ago

The 2nd, but you've reminded me to delete this package.