Describe the bug
Dolphin MVP has mechanisms for inheriting a font setting through the visual hierarchy, right up to the desktop.
In form-type dialogs, where one might want to use a font of a particular size to maintain a pre-designed layout, it is common to set the font on the dialog at design time, and inherit this down to all the controls.
If the inherited font is changed when a window is open, the new font setting should be reflected down into all the inheriting controls. This was broken by my change for #1079 in d187fa462f3c81b895ffe718c5540d6df4f1696e. This introduced a mechanism for propagating settings changes that might affect various aspects of the visual theme, including the desktop (icon) font. The PR included a test that verified the correct propagation of font changes on a settings change, but I overlooked the need to also test that font propagation due to more routine changes continued to work.
To Reproduce
Steps to reproduce the behavior:
Open a View Composer on the default view of AXComponentWizard.
Click on the '…' alongside font (currently Segoe UI 9 point).
In the font dialog switch to Bahnschrift 9pt.
Ok the font dialog
Click over the list in the edit view
Expected behavior
The text is redrawn using the new font.
Actual behavior
The text is redrawn using the system font (because the original font has been free'd).
Describe the bug Dolphin MVP has mechanisms for inheriting a font setting through the visual hierarchy, right up to the desktop. In form-type dialogs, where one might want to use a font of a particular size to maintain a pre-designed layout, it is common to set the font on the dialog at design time, and inherit this down to all the controls. If the inherited font is changed when a window is open, the new font setting should be reflected down into all the inheriting controls. This was broken by my change for #1079 in d187fa462f3c81b895ffe718c5540d6df4f1696e. This introduced a mechanism for propagating settings changes that might affect various aspects of the visual theme, including the desktop (icon) font. The PR included a test that verified the correct propagation of font changes on a settings change, but I overlooked the need to also test that font propagation due to more routine changes continued to work.
To Reproduce Steps to reproduce the behavior:
Expected behavior The text is redrawn using the new font.
Actual behavior The text is redrawn using the system font (because the original font has been free'd).