search

dolphinsmalltalk / Dolphin

Dolphin Smalltalk Core Image
MIT License
301 stars 58 forks source link

Bv consistency004 #1146

Closed brickviking closed 3 years ago

brickviking commented 3 years ago

I'm interested in your thoughts on the first commit c80e8a539b52339f0019a3b66519b9bf0524afdb, relating to UI.ListView lvmRedrawItems:to:, as the comment originally appeared to be copied verbatim from lvmInsertItem: but doesn't appear to match what lvmRedrawItems:to: actually does. I know for experienced Smalltalkers, the code's probably pretty obvious but it's not quite so for me, hence the attempt at a comment.

Most of the rest of these are simple typos, though there's a lot of examples of "xxx receivers ..." when it probably should be "xxx receiver's ..." instead. I haven't collected all of those yet, as there's over two hundred when I last checked.

brickviking commented 3 years ago

Right, that should hopefully be the changes I need to make. Hope you don't mind my slight rewrites.