dolphinsmalltalk / Dolphin

Dolphin Smalltalk Core Image
MIT License
301 stars 58 forks source link

Small changes in many files #1147

Closed brickviking closed 3 years ago

brickviking commented 3 years ago

Includes four sets of patches, including removing redundant "the", and a comment I need clarification on what it was meant to include but left out. More importantly (and I don't know why Dolphin isn't falling over) is the update from dolphindr7.dll to dolphindr8.dll in about 58 resource_Default_view methods. Is there a fallback method so these methods don't tie themselves in knots?

One other thing, I've found in the defaultResourceLibrary at Core/Object Arts/Dolphin/Base/Core.SessionManager.cls:247

defaultResourceLibrary
    "Private - Answer an `External.ResourceLibrary` containing the Dolphin development system resources."

    resourceLibrary isNil
        ifTrue: 
            [resourceLibrary := External.ResourceLibrary
                        open: self defaultResLibPath
                        withAliases: #('dolphindr7' 'dolphindr006' 'dolphindr005' 'dolphindr004' 'dolphindevres' 'dolphindr993')
                        flags: 0].
    ^resourceLibrary!

Should the withAliases: have 'dolphindr8' added to that list, or does Dolphin already know about that file?

Again, an eye over these to see if I missed anything obvious. Thanks for the work you're doing, Blair.

blairmcg commented 3 years ago

One other thing, I've found in the defaultResourceLibrary at Core/Object Arts/Dolphin/Base/Core.SessionManager.cls:247 ... Should the withAliases: have 'dolphindr8' added to that list, or does Dolphin already know about that file?

I forgot to answer that.

No, the list of aliases is things that should map to the lastest resource library if requested instead of it. If you look at defaultResLibPath you will see that it returns DolphinDR8.