search

dolphinsmalltalk / Dolphin

Dolphin Smalltalk Core Image
MIT License
301 stars 58 forks source link

Fix break caused by loss of stdext::hash_value in VS 17.4 #1172

Closed jgfoster closed 1 year ago

jgfoster commented 1 year ago

I can't figure out what changed, but I'm no longer able to build Dolphin using VisualStudio 17.4.3 on Windows 10 or Windows 11. I get an error that hash_value is not found in stdext. I've spent a bit of time learning about this function and looking at how Dolphin uses it, and come up with a one-line change that builds and seems to pass the tests. Comments are welcome especially since if this isn't the right fix then I need another fix!

blairmcg commented 1 year ago

What happened is that Microsoft deprecated it in VS17.3, so you must have done a VS upgrade James. That's how encountered it a couple of weeks ago anyway. I fixed this in the master branch with a1d94acee0eae38512f8839569d87e41448a8e84. It would be better to cherry-pick in that specific commit because it is guaranteed to preserve the existing behaviour (I made a copy of the short deprecated function), and it will keep the history common. I just tried it, and it auto-merges correctly.