search

dolphinsmalltalk / Dolphin

Dolphin Smalltalk Core Image
MIT License
294 stars 58 forks source link

Sliding card tray fires card changed event twice #1279

Closed blairmcg closed 5 months ago

blairmcg commented 5 months ago

Dolphin's sliding card tray fires the currentCardChanging: event twice for a single card change. This bug has existed as long as the SlideyInneyOuteyThing (i.e., since Dolphin 6).

Repro Steps

  1. Open a class hierarchy browser
  2. Select a class and method, and modify the source of the method, but do not save it
  3. Click on the 'Variables' tab of the top-middle browser pane to switch to the instance variables view
  4. When the first prompt to retain changes appears, click Yes to prevent the change of tab

Expected behaviour

A single prompt to retain changes appears, and when 'Yes' is answered the browser selection is left unchanged with method edit still pending

Actual Behaviour

A second prompt to retain changes appears.