dolphinsmalltalk / Dolphin

Dolphin Smalltalk Core Image
MIT License
294 stars 58 forks source link

7.2 High DPI: Menu images can be unclear at certain scales #1289

Closed blairmcg closed 2 days ago

blairmcg commented 5 days ago

Menu images are being scaled-up by Windows at certain scales, making them blurry/jagged.

Steps to reproduce the behavior:

  1. Set displaying scaling to 150%
  2. Open system folder File menu
  3. Note that the File In... and Exit Dolphin images are jagged. The workspace command images are slightly blurry.

Actual

image

Expected

image

Commentary

The images should be drawn at a native scale, but at the CXMENUCHECK x CYMENUCHECK size from system metrics. The menu-check extents can be rather odd, and generally don't match a standard icon size. For example the check-extent at standard 96-dpi is 15x15, and in this case it is better to provide a 16x16 bitmap. At 150% the menu check extent is 25x25, so a 25x25 bitmap should be provided, but rendering the icon at 24x24 to get a native size.