search

dolthub / dolt

Dolt – Git for Data
Apache License 2.0
17.89k stars 507 forks source link

Wire protocol engine test harness #3646

Open zachmu opened 2 years ago

zachmu commented 2 years ago

https://github.com/dolthub/dolt/issues/3645 appears to only manifest over the wire.

We should proactively test for wire compatibility by writing a wire-protocol harness to the engine tests. It should start up a dolt server and talk to it over the local network.

fulghum commented 2 years ago

A recent GMS refactoring introduced some bugs that would have easily manifested in our test suite if we'd had an over-the-wire test harness.

fulghum commented 2 years ago

Another bug with wire serialization that is difficult to catch without running tests over the wire:

PavelSafronov commented 2 years ago

Another bug that could have been caught by over-the-wire test harness:

fulghum commented 1 year ago

Another Dolt bug that only appears through dolt sql-server and not through dolt sql that we could have caught with these tests: