search

dolthub / dolt

Dolt – Git for Data
Apache License 2.0
17.58k stars 498 forks source link

Generate `TEMPORARY TABLE` tags the same as normal `TABLE`s #7999

Closed jycor closed 2 months ago

jycor commented 2 months ago

This PR fixes this particular collision and makes collisions with other temporary tables more unlikely, probably, by using the deterministic random number generator used for generating tags for normal persisting tables.

fixes https://github.com/dolthub/dolt/issues/7995

coffeegoddd commented 2 months ago

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
6718a86 ok 5937457
version total_tests
6718a86 5937457
correctness_percentage
100.0
coffeegoddd commented 2 months ago

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
bfde2ae ok 5937457
version total_tests
bfde2ae 5937457
correctness_percentage
100.0