dolthub / dolt

Dolt – Git for Data
Apache License 2.0
17.36k stars 488 forks source link

enable key range iter #8084

Open max-hoffman opened 1 week ago

max-hoffman commented 1 week ago

There was an issue merging https://github.com/dolthub/dolt/pull/8025 ontop of a revert. Enable the key iteration optimization.

max-hoffman commented 1 week ago

benchmark

github-actions[bot] commented 1 week ago

@max-hoffman workflow run: https://github.com/dolthub/dolt/actions/runs/9703104765

github-actions[bot] commented 1 week ago

Additional work is required for integration with DoltgreSQL.

coffeegoddd commented 1 week ago

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
db954ca ok 5937457
version total_tests
db954ca 5937457
correctness_percentage
100.0
coffeegoddd commented 1 week ago
@max-hoffman DOLT test_name from_latency_p95 to_latency_p95 is_faster
tpcc-scale-factor-1 75.82 74.46 0
test_name server_name server_version tps test_name server_name server_version tps is_faster
tpcc-scale-factor-1 dolt 605b4de7b828f7c68744b5e8b9f6415a3c8698d1 32.87 tpcc-scale-factor-1 dolt db954ca7baeabe99b9635f490410439a4d781edd 32.9 0
coffeegoddd commented 1 week ago
@max-hoffman DOLT read_tests from_latency_median to_latency_median is_faster
covering_index_scan 2.91 2.81 0
groupby_scan 17.01 17.32 0
index_join 5.28 5.28 0
index_join_scan 2.57 2.57 0
index_scan 53.85 53.85 0
oltp_point_select 0.45 0.46 0
oltp_read_only 7.43 7.56 0
select_random_points 0.73 0.78 0
select_random_ranges 0.87 0.92 0
table_scan 55.82 55.82 0
types_table_scan 142.39 142.39 0
write_tests from_latency_median to_latency_median is_faster
oltp_delete_insert 5.99 6.09 0
oltp_insert 2.97 3.02 0
oltp_read_write 13.7 13.95 0
oltp_update_index 3.07 3.07 0
oltp_update_non_index 2.97 3.02 0
oltp_write_only 6.32 6.43 0
types_delete_insert 6.55 6.67 0