Bug fix: Use correct log position in Dolt to MySQL replication heartbeats

dolthub / dolt

Dolt – Git for Data

Apache License 2.0

17.36k stars 488 forks source link

Bug fix: Use correct log position in Dolt to MySQL replication heartbeats #8087

Closed fulghum closed 6 days ago

fulghum commented 1 week ago

Ensure heartbeat events sent from a Dolt primary to a MySQL replica have the latest nextLogPosition populated, otherwise the MySQL replica will close the binlog event stream.

coffeegoddd commented 1 week ago

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
1e757ab	ok	5937457

version	total_tests
1e757ab	5937457

correctness_percentage
100.0

coffeegoddd commented 6 days ago

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
aacb375	ok	5937457

version	total_tests
aacb375	5937457

correctness_percentage
100.0

fulghum commented 6 days ago

The stats: boostrap abort over 1mm rows BATS test has failed four times in a row, but all other tests are passing. I'll send Max a separate PR to disable that test in Lambda BATS.