search

dolthub / dolt

Dolt – Git for Data
Apache License 2.0
17.81k stars 505 forks source link

Bug fix: binlog heartbeat `nextLogPosition` field #8102

Closed fulghum closed 3 months ago

fulghum commented 3 months ago

Heartbeat binlog events must have a correct NextLogPosition field that matches up with the previous events that have been sent in the stream. If not, the replica will shutdown the binlog stream. https://github.com/dolthub/dolt/pull/8087 fixed this issue, but didn't account for when a heartbeat event is sent after the initial Format Description event, but before any user initiated requests. The way to trigger this is to start replica; on the replica, then don't run any commands on the primary and let the first heartbeat go out after the binlog stream has been up for 30s.

coffeegoddd commented 3 months ago

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
3393dc2 ok 5937457
version total_tests
3393dc2 5937457
correctness_percentage
100.0