search

dolthub / dolt

Dolt – Git for Data
Apache License 2.0
17.58k stars 498 forks source link

Return empty dolt_procedures and dolt_schemas tables #8116

Closed macneale4 closed 1 month ago

macneale4 commented 1 month ago

Previously dolt_procedures and dolt_schemas tables could not be selected from if there were not procedures or views. That resulted in errors in the when a dolt CLI client attempted to run dolt diff. This was previously swallowed by the client, but it made the server logs dirty for no reason.

Now, select * from dolt_schemas will result in an empty result set.

I did not add new tests for this as several existing tests were broken by this behavior change. I fixed those instead. Due to change in existinging behavior which people may depend on, this requires a minor version bump.

coffeegoddd commented 1 month ago

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
fbeacfc ok 5937457
version total_tests
fbeacfc 5937457
correctness_percentage
100.0
coffeegoddd commented 1 month ago

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
360384a ok 5937457
version total_tests
360384a 5937457
correctness_percentage
100.0
coffeegoddd commented 1 month ago

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
428696b ok 5937457
version total_tests
428696b 5937457
correctness_percentage
100.0
coffeegoddd commented 1 month ago

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e29db63 ok 5937457
version total_tests
e29db63 5937457
correctness_percentage
100.0
coffeegoddd commented 1 month ago

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
8f6c760 ok 5937457
version total_tests
8f6c760 5937457
correctness_percentage
100.0
coffeegoddd commented 1 month ago

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
626fc01 ok 5937457
version total_tests
626fc01 5937457
correctness_percentage
100.0
coffeegoddd commented 1 month ago

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
34b142e ok 5937457
version total_tests
34b142e 5937457
correctness_percentage
100.0
coffeegoddd commented 1 month ago

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
a228d1e ok 5937457
version total_tests
a228d1e 5937457
correctness_percentage
100.0
coffeegoddd commented 1 month ago

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
8d8916c ok 5937457
version total_tests
8d8916c 5937457
correctness_percentage
100.0
coffeegoddd commented 1 month ago

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
52696c2 ok 5937457
version total_tests
52696c2 5937457
correctness_percentage
100.0
coffeegoddd commented 1 month ago

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
89ea4e4 ok 5937457
version total_tests
89ea4e4 5937457
correctness_percentage
100.0
coffeegoddd commented 1 month ago

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
5524d82 ok 5937457
version total_tests
5524d82 5937457
correctness_percentage
100.0
coffeegoddd commented 1 month ago

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
25d1c98 ok 5937457
version total_tests
25d1c98 5937457
correctness_percentage
100.0