search

dolthub / dolt

Dolt – Git for Data
https://www.dolthub.com
Apache License 2.0
18k stars 516 forks source link

use new decimal type for `dolt diff` #8554

Closed jycor closed 2 weeks ago

jycor commented 2 weeks ago

When modifying column from a decimal with a certain scale/precision to another decimal with different scale/precision, we should display diffs using the new decimal type instead of the old one.

related: https://github.com/dolthub/dolt/pull/8359 fixes: https://github.com/dolthub/dolt/issues/8551

coffeegoddd commented 2 weeks ago

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
4e6464f ok 5937457
version total_tests
4e6464f 5937457
correctness_percentage
100.0
coffeegoddd commented 2 weeks ago

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
a74862c ok 5937457
version total_tests
a74862c 5937457
correctness_percentage
100.0