Fix parameter context for `statement_timeout` and `recovery_target_name`

dolthub / doltgresql

DoltgreSQL - Version Controlled PostgreSQL

Apache License 2.0

1.12k stars 25 forks source link

Fix parameter context for `statement_timeout` and `recovery_target_name` #947

Closed fulghum closed 1 week ago

fulghum commented 1 week ago

The statement_timeout parameter had the wrong context configured, which prevented users from being able to change its value. I did a quick skim of Doltgres' parameters and compared them to pg_catalog.pg_settings and found one other parameter context (recovery_target_name) that didn't match.

Fixes: https://github.com/dolthub/doltgresql/issues/943

github-actions[bot] commented 1 week ago

	Main	PR
Total	42090	42090
Successful	14404	14404
Failures	27686	27686
Partial Successes[^1]	4697	4697

	Main	PR
Successful	34.2219%	34.2219%
Failures	65.7781%	65.7781%

[^1]: These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.