search

dolthub / dolthub-issues

Issues for dolthub.com
https://dolthub.com
4 stars 1 forks source link

Force push not updating PR #101

Open tbantle22 opened 2 years ago

tbantle22 commented 2 years ago

To repro:

  1. Create PR
  2. Update PR with changes
  3. Force push
  4. New changes not reflected in PR

For example: https://www.dolthub.com/repositories/dolthub/SHAQ/pulls/63/compare https://www.dolthub.com/repositories/xrendan/SHAQ/data/leagues-fixed/leagues

tbantle22 commented 2 years ago

Another case of a PR not being updated on push

Repro:

<Add data>
 4580  2021-11-03 13:00:42 dolt commit -m "Add partial 2003 season"
 4581  2021-11-03 13:00:49 dolt push --set-upstream origin ncaa-stats
<MAKE Initial PR here>
 4630  2021-11-03 15:35:31 dolt add players player_season_stat_totals
 4631  2021-11-03 15:35:42 dolt commit -m "Add more teams"
<Revert instead of force pushing to fix the commit without breaking dolthub>
 4661  2021-11-03 17:41:42 dolt revert 8gnijphgsidp2a2vfnm6ue15sm0rq3g3 i5o607sk3tfsogr0s8d9tlpklkmk3upq
 4679  2021-11-03 19:26:20 dolt add players player_season_stat_totals teams
 4680  2021-11-03 19:26:40 dolt commit -m "Add all team player data"
 4681  2021-11-03 19:26:59 dolt push

Commit history: https://www.dolthub.com/repositories/xrendan/SHAQ/commits/ncaa-stats PR: https://www.dolthub.com/repositories/dolthub/SHAQ/pulls/82