dolthub / dolthub-issues

Issues for dolthub.com
https://dolthub.com
4 stars 1 forks source link

Send `secret` with webhook payload so client can authenticate events #506

Closed coffeegoddd closed 6 months ago

coffeegoddd commented 10 months ago

basically for dolthub webhooks, when a user creates a webhook endpoint, they also add a secret (which we store in the db) but we never send that secret on any of the webhook payloads so the client can never verify that the events are truly coming from dolthub

coffeegoddd commented 10 months ago

A stretch goal at a later time is to do what github does as documented here: https://docs.github.com/en/webhooks/using-webhooks/validating-webhook-deliveries

liuliu-dev commented 6 months ago

the service change is in, will close it after the front end change is out