search

dolthub / dolthub-issues

Issues for dolthub.com
https://dolthub.com
4 stars 1 forks source link

pr invalid commit hash provided #540

Closed ShaunSHamilton closed 4 months ago

ShaunSHamilton commented 4 months ago

1) Team member opens PR: https://www.dolthub.com/repositories/sky020/curriculum/pulls/2 2) Repo owner clicks on "View Diff" button: https://www.dolthub.com/repositories/sky020/curriculum/pulls/2/compare?refName=main 3) See invalid commit hash provided error:

Image of error ![image](https://github.com/dolthub/dolthub-issues/assets/51722130/ca4ba72a-7088-43c0-bd40-45a2b0565dec)

I can view the diff by clicking on the hash in the PR view, but not the "View Diff" button:

Image of hash - https://www.dolthub.com/repositories/sky020/curriculum/pulls/2/compare/us54itp1qbrsk5facdbtj2k7n12lgecj..8uat7njebcee6la9lfa173824ctdjq9n?refName=main image

Note: There are/were some other oddities about this PR (another issue to follow)

liuliu-dev commented 4 months ago

Hi @ShaunSHamilton , thanks for the bug report, I will get a fix out tomorrow.

liuliu-dev commented 4 months ago

Hi @ShaunSHamilton , the error has been resolved now, thanks again for the report :)