unexpected behaviour when dropping tables

[ShaunSHamilton]

Admittedly, our workflow is odd, because we are still in the playing/testing phase of using Dolt. So, some of this could be our fault.

Workflow

1) local: drop all tables in database 2) local: run script populating database

• This script is constantly changed, and one of the frequent changes is table names 3) local: commit changes 4) dolthub: open PR to merge

Issue

The dropped tables do not get dropped on the upstream; instead, they are duplicated.

Here is what the Dolthub diff looked like for one such PR


The camelCase named tables were dropped. I paired with a colleague on this, and we are both 100% sure, locally, they were dropped. Then, the script created a bunch of tables (this time in snake_case), and this was added, committed, and pushed to be opened in a PR.

We thought the diff was just a bit wonky. So, merged the PR. Then, we noticed the diff was not necessarily wonky, but the dropped tables were not removed as expected:

Image of `main`


Expected Behaviour

The diff, and subsequent merge should have removed the camelCase named tables, and the snake_case named tables should have been added.

I was not 100% sure where to open this issue. I noticed it in Dolthub, because of the diff view, but please move it.

[liuliu-dev]

Hi @ShaunSHamilton , could you give an example of the workflow or the scripts you ran? It will help us reproduce the bug.

I was able to drop table and merge the changes into main, could you provide me with the script populating database after dropping tables?

Thank you!

[ShaunSHamilton]

@liuliu-dev Sorry for the mess: https://github.com/ShaunSHamilton/freeCodeCamp/blob/dolt/dolt/index.js 🙈

Let me know if anything more could help.

[liuliu-dev]

Hi @ShaunSHamilton thanks for the file.

I could not repro the bug. These are the steps i did:

• check out a branch drop-table locally, drop 2 tables videoLocaleIds and usesMultifileEditor

• modify the constraint of table assignments

• commit and push the changes to remote db

• create a pull request from drop-table to main

• merge the pull request.

this is the diff page of the pull request:

the diff looks correct and after merge job finished, the tables are dropped.

Could you give me more details of your workflow to help me identify the issue? Thanks.

[ShaunSHamilton]

I am not too sure what more to say.

To clarify, I never adjusted the constraints of any table. The workflow is always: 1) drop ALL tables 2) run script to repopulate database 3) commit + push

My image showing the constraint diff is like that, I assume, because I dropped the table and recreated it.

[liuliu-dev]

Hi @ShaunSHamilton ,

Just a few updates:

I've submitted a pull request to fix the table name list in the diff overview. I expect to merge it either today or tomorrow.

Also, I've successfully replicated the merge issue by cloning your database, but I'm still investigating the cause. I'll keep you posted. Apologies for the inconvenience.

[liuliu-dev]

Hi @ShaunSHamilton , do you still have branch feat/update-tables locally on database mot01/curriculum ? could you check if the camelCase named tables are dropped there? Thank you!

[ShaunSHamilton]

@moT01 ☝️

[moT01]

I didn't still have the branch locally. I don't quite have my dolt workflow figured out - or I'm not doing it right or something. I have to reclone my fork often. My guess is that it has something to do with git. I have my dolt database folder inside a folder that's a git repo. So when I am switching git branches, and doing other git things, the dolt references get lost or something? There's still a .dolt folder there, but dolt status gives me "The current directory is not a valid dolt repository." So I try to reclone, and I get this: "data repository already exists: ." - so I delete the .dolt folder and reclone it.

When I did that, and checkout my feat/update-tables branch, the tables do still all exist:

images

[timsehn]

You need to add .dolt to .gitignore or the actual files in the Dolt database will get added to your Git repo. So when you switch branches in Git things will get messed up.

[liuliu-dev]

@moT01 Thanks for checking.

It appears that the camelCase-named tables were not dropped on the feat/update-tables branch, which explains why the diff still shows them and why they remain after the merge.

[ShaunSHamilton]

Thank you for your time looking into this. I have not experienced this since. So, will close the issue until if comes up again.