dolthub / doltpy

A Python API for Dolt
Apache License 2.0
55 stars 13 forks source link

Max/better error msg #125

Closed max-hoffman closed 3 years ago

max-hoffman commented 3 years ago

before:

DoltException: ['dolt', 'sql', '--query', 'describe alecs_hospital_dat;', '--result-format', 'json']

after:

DoltException: ('dolt sql --query describe alecs_hospital_data --result-format json', b'', b'table not found: alecs_hospital_dat\n', 1)
codecov-io commented 3 years ago

Codecov Report

Merging #125 (5f5b273) into master (d7764b9) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   43.93%   43.93%           
=======================================
  Files          19       19           
  Lines        1625     1625           
=======================================
  Hits          714      714           
  Misses        911      911           
Impacted Files Coverage Δ
doltpy/cli/dolt.py 52.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d7764b9...5f5b273. Read the comment docs.

VinaiRachakonda commented 3 years ago

LGTM. Feel like in the future we should aim for something better