search

dolthub / doltpy

A Python API for Dolt
Apache License 2.0
55 stars 13 forks source link

Add max connections and password capabilities. #151

Closed VinaiRachakonda closed 3 years ago

VinaiRachakonda commented 3 years ago

This pr introduces ability to connect with mysql with a password as well as introduces the max_connections flag.

max-hoffman commented 3 years ago

Adding a test to avoid a decrease in coverage % would be nice, but otherwise looks good.

codecov-commenter commented 3 years ago

Codecov Report

Merging #151 (c163bfa) into master (2c0e198) will increase coverage by 0.62%. The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   41.95%   42.57%   +0.62%     
==========================================
  Files          23       23              
  Lines         963      970       +7     
==========================================
+ Hits          404      413       +9     
+ Misses        559      557       -2
Impacted Files Coverage Δ
doltpy/sql/sql.py 78.57% <71.42%> (+1.51%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2c0e198...c163bfa. Read the comment docs.